Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support predeclared and asciicheck #35895

Merged
merged 9 commits into from
Jul 3, 2022
Merged

*: support predeclared and asciicheck #35895

merged 9 commits into from
Jul 3, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jul 2, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #35345

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei
*: enable predeclared
897f9a6 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: enable predeclared
a737533 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 2, 2022
@hawkingrei
*: enable predeclared
e0f9ce1 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: enable predeclared
e7f66cc 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: enable predeclared
a1db346 
Signed-off-by: Weizhen Wang <[email protected]>
@sre-bot
Copy link
Contributor

sre-bot commented Jul 2, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/5d9ca42cc720302f2f15c74c4e6d960b9f35d0b1

@hawkingrei hawkingrei requested a review from tisonkun July 2, 2022 16:39
@hawkingrei
*: enable predeclared
7754c0e 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 2, 2022
@hawkingrei
*: enable predeclared
c36d0a1 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: enable predeclared
4c9af10 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: enable predeclared
5d9ca42 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei mentioned this pull request Jul 3, 2022
Closed
7 tasks
@hawkingrei hawkingrei changed the title *: support predeclared *: support predeclared and asciicheck Jul 3, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 3, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 3, 2022
@tisonkun
Copy link
Contributor

tisonkun commented Jul 3, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5d9ca42

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 3, 2022
@ti-chi-bot ti-chi-bot merged commit 57ff144 into pingcap:master Jul 3, 2022
@hawkingrei hawkingrei deleted the support_predeclared branch July 3, 2022 09:27
@sre-bot
Copy link
Contributor

sre-bot commented Jul 3, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 1, success 10, total 11 48 min New failing
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 9 min 40 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 50 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 10 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 32 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 1 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 51 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@tisonkun tisonkun tisonkun approved these changes

@disksing disksing Awaiting requested review from disksing

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hawkingrei @ti-chi-bot @sre-bot @tisonkun @tangenta